Demonstrate and extend printf truncation#26
Open
knz wants to merge 4 commits intocockroachdb:masterfrom
Open
Conversation
knz
force-pushed
the
20210903-truncation
branch
2 times, most recently
from
808ab05 to
26eff89
Compare
The upstream printf code already has support for string truncation. This commit demonstrates/tests it via unit tests.
This should have been done when format.go moved to a new package.
(Using the refresh.sh script)
When the flag `!` is passed in combination with a
precision (e.g. `%!.3v`), the truncation code now adds an
ellipsis (`…`) if truncation has actually occurred.
For example:
`printf("%!.3s", "hel")` -> `‹hel›`
`printf("%!.3s", "hello")` -> `‹hel…›`
knz
force-pushed
the
20210903-truncation
branch
from
26eff89 to
afd883e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commits for details.
Supersedes #25
Also a new feature:
When the flag
!is passed in combination with aprecision (e.g.
%!.3v), the truncation code now adds anellipsis (
…) if truncation has actually occurred.For example:
printf("%!.3s", "hel")->‹hel›printf("%!.3s", "hello")->‹hel…›This change is